Skip to content

[release-4.16] CNV-43973: HCP custom tolerations integration #2788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.16
Choose a base branch
from
Open

[release-4.16] CNV-43973: HCP custom tolerations integration #2788

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2441

/assign rtheis

@davidvossel
hcp tolerations integration
3f58674 
Signed-off-by: David Vossel <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 27, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 27, 2025 •
edited by openshift-ci bot
Loading

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: CNV-43973

In response to this:

This is an automated cherry-pick of #2441

/assign rtheis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2025

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: rtheis.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

This is an automated cherry-pick of #2441

/assign rtheis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign dougbtv for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rtheis
Copy link

rtheis commented Aug 27, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 27, 2025
@rtheis
Copy link

rtheis commented Aug 28, 2025

/retest-required

1 similar comment
@rtheis
Copy link

rtheis commented Aug 28, 2025

/retest-required

@rtheis
Copy link

rtheis commented Aug 28, 2025

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

@rtheis: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 28, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn 3f58674 link false /test e2e-openstack-ovn
ci/prow/4.16-upgrade-from-stable-4.15-e2e-azure-ovn-upgrade 3f58674 link false /test 4.16-upgrade-from-stable-4.15-e2e-azure-ovn-upgrade
ci/prow/e2e-aws-hypershift-ovn-kubevirt 3f58674 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-aws-ovn-windows 3f58674 link true /test e2e-aws-ovn-windows
ci/prow/e2e-aws-sdn-upgrade 3f58674 link false /test e2e-aws-sdn-upgrade
ci/prow/e2e-aws-live-migration-sdn-ovn-rollback 3f58674 link false /test e2e-aws-live-migration-sdn-ovn-rollback
ci/prow/security 3f58674 link false /test security
ci/prow/e2e-aws-ovn-serial 3f58674 link false /test e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rtheis
Copy link

rtheis commented Sep 8, 2025

@jcaamano can you please help me to close this cherry-pick that I opened?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@jcaamano jcaamano Awaiting requested review from jcaamano

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @rtheis @davidvossel